core: simplify compute_refreshing_shares() #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #940 +/- ##
==========================================
+ Coverage 77.39% 78.11% +0.72%
==========================================
Files 41 41
Lines 4503 4460 -43
==========================================
- Hits 3485 3484 -1
+ Misses 1018 976 -42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
conradoplg
force-pushed
the
simplify-refresh
branch
from
76fb1d0 to
c9c0714
Compare
natalieesk
reviewed
Jan 23, 2026
Contributor
natalieesk
left a comment
natalieesk
left a comment
There was a problem hiding this comment.
This is good, just needs conflicts resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #922 which needs to be merged first
Closes #916